| | | 1 | | using System.Diagnostics; |
| | | 2 | | using Microsoft.EntityFrameworkCore; |
| | | 3 | | using Microsoft.EntityFrameworkCore.Diagnostics; |
| | | 4 | | using Serilog; |
| | | 5 | | |
| | | 6 | | namespace OzonOrdersWeb.Observability; |
| | | 7 | | |
| | | 8 | | /// <summary> |
| | | 9 | | /// Регрессия #857: встроенное предупреждение EF Core FirstWithoutOrderByAndFilterWarning не содержит |
| | | 10 | | /// места вызова — фоновое задание, компилирующее такой запрос, найти по нему нельзя. |
| | | 11 | | /// Встроенную запись опускаем до Debug, а вместо неё пишем Warning с кадрами стека Studio2: |
| | | 12 | | /// компиляция запроса идёт синхронно в стеке вызывающего метода. |
| | | 13 | | /// </summary> |
| | | 14 | | public static class FirstWithoutOrderByDiagnostics |
| | | 15 | | { |
| | 1 | 16 | | private static readonly string[] OwnFramePrefixes = ["OzonOrdersWeb.", "Services.", "OzonRepositories."]; |
| | | 17 | | |
| | | 18 | | public static TBuilder AddFirstWithoutOrderByDiagnostics<TBuilder>( |
| | | 19 | | this TBuilder options, Serilog.ILogger? logger = null) where TBuilder : DbContextOptionsBuilder |
| | | 20 | | { |
| | 3 | 21 | | options |
| | 3 | 22 | | .ConfigureWarnings(w => w.Log((CoreEventId.FirstWithoutOrderByAndFilterWarning, LogLevel.Debug))) |
| | 3 | 23 | | .LogTo( |
| | 33 | 24 | | (eventId, _) => eventId == CoreEventId.FirstWithoutOrderByAndFilterWarning, |
| | 4 | 25 | | eventData => Report(eventData, logger ?? Log.Logger)); |
| | 3 | 26 | | return options; |
| | | 27 | | } |
| | | 28 | | |
| | | 29 | | internal static void Report(EventData eventData, Serilog.ILogger logger) => |
| | 1 | 30 | | logger.Warning( |
| | 1 | 31 | | "EF Core: First/FirstOrDefault без OrderBy и фильтра даёт непредсказуемую строку. Вызов: {CallSite}", |
| | 1 | 32 | | OwnCallSite(new StackTrace(skipFrames: 1))); |
| | | 33 | | |
| | | 34 | | internal static string OwnCallSite(StackTrace stackTrace) |
| | | 35 | | { |
| | 1 | 36 | | var frames = stackTrace.GetFrames() |
| | 81 | 37 | | .Select(frame => frame.GetMethod()) |
| | 81 | 38 | | .Where(method => method?.DeclaringType?.FullName is { } name |
| | 240 | 39 | | && OwnFramePrefixes.Any(prefix => name.StartsWith(prefix, StringComparison.Ordinal)) |
| | 81 | 40 | | && name != typeof(FirstWithoutOrderByDiagnostics).FullName) |
| | 2 | 41 | | .Select(method => Describe(method!)) |
| | 1 | 42 | | .Distinct() |
| | 1 | 43 | | .Take(5) |
| | 1 | 44 | | .ToList(); |
| | 1 | 45 | | return frames.Count > 0 ? string.Join(" <- ", frames) : "—"; |
| | | 46 | | } |
| | | 47 | | |
| | | 48 | | // Async-метод виден в стеке как «Class+<Method>d__5.MoveNext» — показываем «Class.Method». |
| | | 49 | | private static string Describe(System.Reflection.MethodBase method) |
| | | 50 | | { |
| | 2 | 51 | | var typeName = method.DeclaringType!.FullName!; |
| | 2 | 52 | | var nested = typeName.IndexOf("+<", StringComparison.Ordinal); |
| | 2 | 53 | | if (nested < 0) |
| | 1 | 54 | | return $"{typeName}.{method.Name}"; |
| | | 55 | | |
| | 1 | 56 | | var end = typeName.IndexOf('>', nested); |
| | 1 | 57 | | return end > nested + 2 |
| | 1 | 58 | | ? $"{typeName[..nested]}.{typeName[(nested + 2)..end]}" |
| | 1 | 59 | | : typeName[..nested]; |
| | | 60 | | } |
| | | 61 | | } |